This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Pass Prometheus Registry into Client
#5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
reviewed
Mar 4, 2020
NikVolf
reviewed
Mar 4, 2020
NikVolf
approved these changes
Mar 5, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 6, 2020
* Add a few metrics to Client * Improve PrometheusConfig * Fix client docs
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
* Add a few metrics to Client * Improve PrometheusConfig * Fix client docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're probably going to want to instrument
Clientin the future, so this PR contains the refactorings needed to pass it the prometheusRegistry.