-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
Will it still be possible, given this, to manually build the setup? There is a situation in #4947 that you can see and it cannot be really tracked with this benchmarking setup. One of the parameters is Enum Mode {
BenchMode1,
BenchMode2,
} and stepping over this is not possible. |
I think you can make two benchmarks out of the enum and refactor the common parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, very ergonomic. Maybe we want @shawntabrizi or @gavofyork to take a look to my changes (balances/benchmarking
mostly) before merging.
So, the reports say that it consistently slightly improves on wasm but is sometimes a regression on native ... how do you want to proceed? |
Wrong PR :)? I'll merge once CI finish, other benchmarks depend on this. |
* MAcro benchamrks * Iterative macro * Tidying it up. * Macro improvements * Bits.. * Last benchmaks. * Repo benchmark macro * Add the possibility of evaluating arbitrary expressions in a benchmaark * Better syntax and docs * Update `BenchmarkParameter` * Add `ignore` to sudo-code in docs * First try of timestamp implementation. * Fix macro docs, remove warnings. * Use macro in balances pallet. * Make some space in frame benchmarking. * Remove _benchmarks_seed variable. * Bump impl_version. Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Marcio Diaz <[email protected]>
Fixes #4861