This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Pallets: Assets destroy_accounts releases the deposit
#14443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
A0-please_review
muharem
removed
the
D3-trivial 🧸
kianenigma
reviewed
Jun 23, 2023
kianenigma
approved these changes
Jun 23, 2023
sam0x17
approved these changes
Jun 23, 2023
gavofyork
approved these changes
Jun 25, 2023
Co-authored-by: Kian Paimani <[email protected]>
louismerlin
added
D1-audited 👍
juangirini
approved these changes
Jun 27, 2023
|
bot merge |
|
Waiting for commit status. |
|
bot rebase |
|
Rebased |
|
bot merge |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…4443) * assset accounts destroy releases the deposit * enumerate * Update frame/assets/src/functions.rs Co-authored-by: Kian Paimani <[email protected]> * import defensive from frame_support --------- Co-authored-by: Gavin Wood <[email protected]> Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destroy accounts should release the existence deposits if any.
Currently, when accounts are being destroyed, deposits are not released. The
dead_accountfunction is executed forcefully, allowing the removal of the asset even if some accounts were not removed correctly.In the PR we release the deposits on the account destroy and do not force the
dead_accountfunction.