This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
github-actions
bot
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
May 16, 2022
github-actions
bot
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
May 16, 2022
ggwpez
added
B5-clientnoteworthy
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
and removed
A0-please_review
Pull request needs code review.
B5-clientnoteworthy
labels
May 16, 2022
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
shawntabrizi
changed the title
More
More May 16, 2022
benchmark manchine
argsbenchmark machine
args
So what's the probability of it failing with only |
koute
approved these changes
May 17, 2022
@koute yea good idea. |
shawntabrizi
approved these changes
May 17, 2022
bot merge |
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* Add ExecutionLimits to sc-sysinfo and return float Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Increase benchmarking duration and add options Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix tests Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix tests Signed-off-by: Oliver Tale-Yazdi <[email protected]>
3 tasks
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Add ExecutionLimits to sc-sysinfo and return float Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Increase benchmarking duration and add options Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix tests Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix tests Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Add ExecutionLimits to sc-sysinfo and return float Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Increase benchmarking duration and add options Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix tests Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix tests Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the
benchmark machine
command some dozen times on the ref hardware and theBlake2-256
seems to be the only failing one. It runs for only 100ms which is probably too short to get reproducible results.Changes:
sc-sysinfo
returnf64
for more precisionsc-sysinfo
The benchmark worked 27 times in a row, then failed with 0.4% outside the tolerance for the disk benchmark. Should be good enough for now.