Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add event tests to Nomination Pools #11349

Merged
merged 10 commits into from
May 6, 2022

Conversation

rossbulat
Copy link

This PR adds event asserts to the nomination pools pallet, ensuring the correct events are emitted.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 4, 2022
@rossbulat rossbulat added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 4, 2022
@kianenigma kianenigma requested review from shawntabrizi and bkchr May 4, 2022 13:44
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments, looks good!

frame/nomination-pools/src/tests.rs Show resolved Hide resolved
frame/nomination-pools/src/tests.rs Show resolved Hide resolved
frame/nomination-pools/src/tests.rs Show resolved Hide resolved
frame/nomination-pools/src/tests.rs Show resolved Hide resolved
@kianenigma
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit dedfef2 into master May 6, 2022
@paritytech-processbot paritytech-processbot bot deleted the rb-pools-eventify-tests branch May 6, 2022 09:44
godcodehunter pushed a commit to sensoriumxr/substrate that referenced this pull request Jun 22, 2022
* fix a few things with nomination pools

* fix typo

* fix build

* eventify tests

* Update frame/nomination-pools/src/tests.rs

Co-authored-by: Kian Paimani <[email protected]>

* fmt

* comments

* split

Co-authored-by: kianenigma <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* fix a few things with nomination pools

* fix typo

* fix build

* eventify tests

* Update frame/nomination-pools/src/tests.rs

Co-authored-by: Kian Paimani <[email protected]>

* fmt

* comments

* split

Co-authored-by: kianenigma <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* fix a few things with nomination pools

* fix typo

* fix build

* eventify tests

* Update frame/nomination-pools/src/tests.rs

Co-authored-by: Kian Paimani <[email protected]>

* fmt

* comments

* split

Co-authored-by: kianenigma <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants