-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit smoldot's CPU usage to 50% #900
Conversation
@@ -10,6 +10,7 @@ | |||
### Changed | |||
|
|||
- Update @substrate/smoldot-light to [version 0.6.8](https://github.com/paritytech/smoldot/blob/main/bin/wasm-node/CHANGELOG.md#068---2022-03-23) ([#890](https://github.com/paritytech/substrate-connect/pull/890)) | |||
- The smoldot background worker will now bound its CPU usage to 50% of one CPU on average. ([#900](https://github.com/paritytech/substrate-connect/pull/900)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure if this is something that end user should know. Its extension-internal - right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's visible to the user that the usage of their CPU is bounded to 50%
There is something print when zombienet tests are running other than
This sample is from a param of 0.75 (I think) passed to the With my none-existent rust skills I can only assume that the issue comes either in here or here but again my rust is very bad to say for sure. |
Despite the bugs in smoldot, it would still be great to figure out why this |
Went through zombienet code with @pepoviola . The
|
Yes, this will be fixed in the next version of zombienet. |
This change is there really to avoid a worst case scenario where smoldot has an issue that causes it to never go to sleep.
This will very slightly slow down syncing (verifying the warp sync proof is a pure CPU operation), but avoiding big CPU spikes is more desirable than saving a few milliseconds.