Add CJS support to connect #1142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect into nik-esm-and-cjs
tomaka
reviewed
Jul 13, 2022
| ? specRaw | ||
| : (specRaw as unknown as { default: string }).default | ||
| // Typescript converts dynamic `await import()` to `require()` when commonJs is used which | ||
| // is not correct and leads to error. The following import works correctly but requires as |
This reverts commit dceabf5.
…k-cjs-support-connect-extension-protocol
…ect into nik-esm-and-cjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CJS support to
@substrate/connectNOTE: This SHOULD NOT be merged prior to a new release of smoldot once #2487 is merged. The reason is that for CJS version of substrate-connect to work the CJS version of smoldot must have been released.
For releasing the following steps must be followed:
A) Release new version of
smoldot(as mentioned above) once #2487 is mergedB) Release new version of
connect-extension-protocolonce #1143C) Update versions of
smoldotandconnect-extension-protocolin this PR and merge it.