Cargo fmt + minor stuff #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
LGTM.
I would prefer it if the changes to the rejection error to include the body were in a separate PR but I'm ok merging it here too if @jsdw and @niklasad1 are on-board as well.
maciejhirsz
force-pushed
the
mh-boyscouting
branch
from
9f5acde to
88f4614
Compare
|
Rolled back the body, it works, but it doesn't even show up in firefox dev tools, so it's kind of useless :) |
|
One thing though: we have a semi-standard So it'd be: hard_tabs = true
max_width = 120
use_small_heuristics = "Max"
edition = "2018" |
jsdw
reviewed
Jun 15, 2021
src/base.rs
Outdated
Comment on lines
574
to
584
| Error::Io(e) => write!(f, "i/o error: {}", e), | ||
| Error::UnknownOpCode => f.write_str("unknown opcode"), | ||
| Error::ReservedOpCode => f.write_str("reserved opcode"), | ||
| Error::FragmentedControl => f.write_str("fragmented control frame"), | ||
| Error::InvalidControlFrameLen => f.write_str("invalid control frame length"), | ||
| Error::InvalidReservedBit(n) => write!(f, "invalid reserved bit: {}", n), | ||
| Error::PayloadTooLarge { actual, maximum } => write!( | ||
| f, | ||
| "payload too large: len = {}, maximum = {}", | ||
| actual, maximum | ||
| ), |
There was a problem hiding this comment.
That's a shame; I liked how this had been laid out :)
Applied! |
niklasad1
approved these changes
Jun 15, 2021
jsdw
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmt(fixes Isrustfmtwelcome here? #28).concat!macro in response headers to make them a notch faster.AddedbodytoResponse::Rejectso the user can send intelligible errors back.