Handle CLOSE reason as Incoming #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pierre Krieger <[email protected]>
tomaka
reviewed
Apr 14, 2021
tomaka
approved these changes
Apr 14, 2021
…SE frame we should not bail early.
This was referenced Apr 20, 2021
maciejhirsz
approved these changes
May 27, 2021
Because otherwise we'd do an early exit and the code higher up the call chain would not see the |
niklasad1
approved these changes
May 27, 2021
mxinden
added a commit
to libp2p/rust-libp2p
that referenced
this pull request
Oct 30, 2021
Pass websocket CLOSE reason to the app as an `Incoming::Closed(soketto::CloseReason)`. This PR is a companion to paritytech/soketto#31 and lets applications know what the remote end claimed to be the reason for closing the connection (if any). `IncomingData` is now renamed to `Incoming` and the actual data (text or binary) is moved into its own `Data` enum, which in turn allows `into_bytes()` and the `AsRef` impl to apply more sanely to something that is actually data. Co-authored-by: David Palm <[email protected]>
santos227
pushed a commit
to santos227/rustlib
that referenced
this pull request
Jun 20, 2022
Pass websocket CLOSE reason to the app as an `Incoming::Closed(soketto::CloseReason)`. This PR is a companion to paritytech/soketto#31 and lets applications know what the remote end claimed to be the reason for closing the connection (if any). `IncomingData` is now renamed to `Incoming` and the actual data (text or binary) is moved into its own `Data` enum, which in turn allows `into_bytes()` and the `AsRef` impl to apply more sanely to something that is actually data. Co-authored-by: David Palm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a remote sends us a CLOSE message it may contain a reason code and "application data" with further details about why the connection was closed.
Before this PR there was no way for applications using
sokettoto know what the code/data was sent from the remote.Further context here.
This is an alternative to #29 and returns the close reason as
Incoming::Closedinstead ofError::Closed(reason).