Fix wrong order of parachain blocks at initialization #2965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we subscribe to parachain blocks, the subscription confirmation contains the list of all blocks that already exist. This list of blocks needs to be ordered from parent to child, and the field is actually named
non_finalized_blocks_ancestry_order
("ancestry order") in order for everyone to get the memo.Unfortunately, the author of the parachains code (me) didn't get the memo, and the parachain blocks aren't properly ordered.
This leads to a panic in
runtime_service.rs
because it assumes that the ordering is correct.