-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make signature verification customizable in the host module #2955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.
twiggy diff reportDifference in .wasm size before and after this pull request.
|
I also did |
This is indeed better. Will try integrate this. |
Because I am using smoldot/src/executor/runtime_host.rs Line 160 in 6df249e
|
cc @xlc
After looking at #2952, I thought that the approach in this PR is a better idea.
As shown in the changes to
runtime_host.rs
andread_only_runtime_host.rs
, you now have a new variant calledSignatureVerification
that allows you to overwrite the verification if you so desire.As I was implemented this PR, I noticed that the implementation of
ext_crypto_ecdsa_verify
loads the message from the first parameter, which is actually the signature. Oops. This is fixed at the same time.