Fix starting requests on shutting down connections #2847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a TODO left in the code. I'm slowing catching up on networking TODOs.
Fix #2777
Fix #2841
This PR changes
has_established_connection
to return false if all the connections are shutting down.To clear up any ambiguity, I've also renamed it to
can_start_requests
, because determining whether we can send requests is the reason why this function is called.