Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer discard justifications of blocks that were already known #2800

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Sep 29, 2022

Fixes a TODO in the code.

This TODO was from a time when we were handling justifications very naively by attaching them to blocks.
After #2400, we now properly handle justifications by attaching them to a (block, source) tuple, meaning that the problem of replacing existing justifications with other ones doesn't exist anymore.

This TODO should have been fixed in #2400, but I forgot.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────
        +754 ┊ smoldot::sync::all_forks::AddBlockOccupied<TBl,TRq,TSrc>::replace::he158aecb8287a97b
        -634 ┊ smoldot::sync::all_forks::AddBlockOccupied<TBl,TRq,TSrc>::replace::hbf3503201a3e9780
         +93 ┊ smoldot::sync::all_forks::FinishAncestrySearch<TBl,TRq,TSrc>::add_block::h9adac7250d79add4
         +42 ┊ smoldot::sync::all_forks::AddBlockOccupied<TBl,TRq,TSrc>::cancel::h5cac5d15d480d406
         -24 ┊ smoldot::sync::all::AllSync<TRq,TSrc,TBl>::blocks_request_response::h7d78c4f7a1206829
         +16 ┊ data[0]
        +346 ┊ Σ [6 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Oct 4, 2022
@mergify mergify bot merged commit c3e5fb5 into paritytech:main Oct 4, 2022
@tomaka tomaka deleted the no-discard-just branch October 4, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant