Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a chainHead_unstable_finalizedDatabase JSON-RPC method #2749

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Add a chainHead_unstable_finalizedDatabase JSON-RPC method #2749

merged 4 commits into from
Sep 15, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Sep 14, 2022 •
edited
Loading

cc #2456

See the issue description for more context.

mergify[bot]
mergify bot approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@tomaka tomaka mentioned this pull request Sep 14, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────
      +45357 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hb3b94fa0f03b6fb0
      -44761 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hae48ea587fa18586
      +10991 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h71b96e2bf08729b1
      -10876 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h50318c6c79cc6c29
      +10635 ┊ smoldot::json_rpc::methods::Response::to_json_response::h6ceea4cbbb2a587d
      -10528 ┊ smoldot::json_rpc::methods::Response::to_json_response::hca6a060808d3da20
       +6013 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h3cfe4f029962a788
       -6013 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hdcc28455a90526ca
       +4660 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h53b0e0e73281b955
       -4660 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd9ae2d3c70c718f5
       +4232 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::h6113d969daca0c3a
       -4170 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::h8cd4e448618be521
       -2720 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h8af9e143a7c6d290
       +2720 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha45386a525f1e66b
       -2075 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h49f26e9bfdb89e08
       +2075 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h7c3546bdc9fc90eb
       -1725 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb13e3df9452922c1
       +1725 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd1273308823cdc4f
       +1584 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h43075630ed9326ef
       -1584 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hab264eae66e041e8
       +2827 ┊ ... and 198 more.
       +5770 ┊ Σ [218 Total Rows]

melekes
melekes approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Sep 15, 2022
@mergify mergify bot merged commit f70204e into paritytech:main Sep 15, 2022
@tomaka tomaka deleted the chainHead_unstable_finalizedDatabase branch September 15, 2022 07:51
@tomaka tomaka mentioned this pull request Sep 28, 2022
Merged
mergify bot added a commit that referenced this pull request Sep 28, 2022
@tomaka @mergify
Remove Chain.databaseContent function (#2791)
313eee2 
Close #2456

This PR removes the `Chain.databaseContent` function from the public
API. Users are supposed to use the
`chainHead_unstable_finalizedDatabase` JSON-RPC function that was added
in #2749 instead.

This is an API breaking change. Since
#2778 has been merged and is a
breaking change, let's do other breaking changes at the same time.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @melekes