Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2618
It turns out that when a handshake timeout or protocol error happens, we set the connection's state to
ShutdownWaitingAck { was_api_reset: false }
.was_api_reset: false
indicates that the shutdown wasn't initiated through the public API.Unfortunately, other parts of the code interpret
was_api_reset: false
as meaning "was initiated through the coordinator", as it assumes that a shutdown is only ever initiated either through the public API or through the coordinator.This omits the third way to start a shutdown: when a handshake timeout or protocol error happens.