-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused fallback protocol names system #2569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.
It turns out that this was even mis-implemented. |
twiggy diff reportDifference in .wasm size before and after this pull request.
|
Ages ago, I added a dummy field called
fallback_protocol_names
that lets you specify a list of alternative protocol names that would be negotiated if the main one isn't supported by the remote.Substrate has a similar feature, and it's very useful in order to do protocol upgrades. (e.g. #2116)
Unfortunately this has never been implemented.
Instead of leaving this dummy feature here, this PR just removes it. It can always be added back properly in the future.