Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base64 decoding function #2533

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Fix base64 decoding function #2533

merged 3 commits into from
Jul 19, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 19, 2022

It turns out that the cause of #2523 was a bug in the base64 decoding code.
This PR replaces this code with something that seems to work.

@tomaka tomaka mentioned this pull request Jul 19, 2022
Merged
mergify[bot]
mergify bot approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@tomaka tomaka requested a review from wirednkod July 19, 2022 16:03
@tomaka
Copy link
Contributor Author

tomaka commented Jul 19, 2022

I didn't realize that NodeJS doesn't have atob.
I'll change the zlibInflate function to also include the base64 decoding step.

@tomaka tomaka marked this pull request as draft July 19, 2022 16:08
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@wirednkod wirednkod self-requested a review July 19, 2022 16:16
@tomaka tomaka marked this pull request as ready for review July 19, 2022 16:17
@tomaka
Copy link
Contributor Author

tomaka commented Jul 19, 2022

Tested in both NodeJS and browsers.

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jul 19, 2022
@mergify mergify bot merged commit b908304 into paritytech:main Jul 19, 2022
@tomaka tomaka deleted the fix-base64-decode branch July 19, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@wirednkod wirednkod Awaiting requested review from wirednkod

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @wirednkod