Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tiny-inflate and restore pako #2532

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 19, 2022

Fix #2523
More or less reverts #2506

It seems that tiny-inflate sometimes doesn't work. My only hypothesis is a bug in that code. Since I'm not going to fix that bug, let's put back a library that is known to work.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jul 19, 2022
@mergify mergify bot merged commit 9018b36 into paritytech:main Jul 19, 2022
@tomaka tomaka deleted the restore-pako branch July 19, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS demo returns Error while adding chain: Error: Data error
2 participants