Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blockNumberBytes field in chain specs #2512

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 15, 2022

cc #2478

The change is rather straight forward: we add a new optional blockNumberBytes field in the chain specs format and pass its value around. The value defaults to 4 if it's missing.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────
       +4227 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb10ed4dababbd50c
       -4214 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h14ece9dd36df2cd6
       +3226 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h2498be66670d547f
       -3122 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha40c4403a162aba0
       -2136 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h78455e4882c3a983
       +2135 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h9bc060acb423dd39
       +1327 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::he50e7bf7341f20a0
       -1296 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd72e904c63df3033
       +1018 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h4546461ffef36006
       -1018 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc4be4ba165e4506e
        -945 ┊ <futures_util::future::future::shared::Shared<Fut> as core::future::future::Future>::poll::ha3978bf09d40e019
        +945 ┊ <futures_util::future::future::shared::Shared<Fut> as core::future::future::Future>::poll::hf2400c46d828d658
        +711 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h6771f3fbb8df3a52
        -711 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha7c0f35a711f8e98
        +671 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::h070195c8739260ea
        -671 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::h105432efc18949c5
        +550 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h39c87466f56e82f3
        -550 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h7b73015b0b805350
        -513 ┊ futures_channel::oneshot::Inner<T>::send::hc4ae0a5e3b748553
        -466 ┊ futures_util::future::future::shared::Inner<Fut>::take_or_clone_output::h68e861dfff5217b5
        +997 ┊ ... and 184 more.
        +503 ┊ Σ [204 Total Rows]

src/chain_spec.rs Show resolved Hide resolved
@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jul 18, 2022
@mergify mergify bot merged commit fa57288 into paritytech:main Jul 18, 2022
@tomaka tomaka deleted the block-number-bytes-chain-spec branch July 18, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants