Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence NoPeers discovery errors #2476

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 6, 2022

People keep mentioning this warning about no peers, but there's actually nothing that can be done anyway, and thus no point in printing the warning.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────
        +257 ┊ <smoldot::network::kademlia::DecodeFindNodeResponseError as core::fmt::Debug>::fmt::h3bb361b11c516709
        +208 ┊ data[0]
        +158 ┊ <smoldot::network::service::KademliaFindNodeError as core::fmt::Debug>::fmt::hfd2a1e15d280f687
        +157 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hca1ac2aa7e090d3c
        +127 ┊ <smoldot::network::service::DiscoveryError as core::fmt::Debug>::fmt::h5cfbb2176e6bfc48
         +70 ┊ <smoldot::libp2p::multiaddr::FromVecError as core::fmt::Debug>::fmt::h3e1d448e30e50d8c
         +20 ┊ <smoldot::network::kademlia::ProtobufDecodeError as core::fmt::Debug>::fmt::h61934490a3c05d5c
         +20 ┊ elem[0]
         +17 ┊ <&T as core::fmt::Debug>::fmt::h12bfc46d392c72fb
         +17 ┊ <&T as core::fmt::Debug>::fmt::h4ad1fc00e3d41706
         +14 ┊ <&T as core::fmt::Debug>::fmt::h6d50a40819b163a6
         +14 ┊ <&T as core::fmt::Debug>::fmt::hb9638d155cf0bf92
          +4 ┊ core::ptr::drop_in_place<&smoldot::libp2p::multiaddr::FromVecError>::haab26b9cdfb85791
          +4 ┊ core::ptr::drop_in_place<&smoldot::libp2p::peer_id::FromBytesError>::hd5fced6dbeaa76de
          +4 ┊ core::ptr::drop_in_place<&smoldot::network::kademlia::DecodeFindNodeResponseError>::hf27c0f8bfae42397
          +4 ┊ core::ptr::drop_in_place<&smoldot::network::kademlia::ProtobufDecodeError>::h217bafa224216645
          +4 ┊ core::ptr::drop_in_place<&smoldot::network::service::KademliaFindNodeError>::h97e27b519b87037a
       +2525 ┊ Σ [17 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jul 7, 2022
@mergify mergify bot merged commit 6947e09 into paritytech:main Jul 7, 2022
@tomaka tomaka deleted the silence-discovery-errors branch July 7, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants