Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass type: "module" to new Worker() #2426

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Pass type: "module" to new Worker() #2426

merged 4 commits into from
Jun 23, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jun 23, 2022 •
edited
Loading

Deno throws an exception if we call new Worker without type: "module".

See the comments for more information.

cc @harrysolovay

mergify[bot]
mergify bot approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@wirednkod
Copy link
Contributor

Maybe the info in the README.md should be updated accordingly @tomaka

@tomaka tomaka requested review from wirednkod and harrysolovay June 23, 2022 12:43
@harrysolovay harrysolovay mentioned this pull request Jun 23, 2022
Closed
@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jun 23, 2022
@mergify mergify bot merged commit 8f79fe3 into paritytech:main Jun 23, 2022
@tomaka tomaka deleted the type-module branch June 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@wirednkod wirednkod wirednkod approved these changes

@melekes melekes melekes approved these changes

@harrysolovay harrysolovay Awaiting requested review from harrysolovay

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaka @wirednkod @melekes