-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for digest item other type #2425
Merged
mergify
merged 4 commits into
paritytech:main
from
fanyang1988:features/add-digest-other
Jun 24, 2022
Merged
Add support for digest item other type #2425
mergify
merged 4 commits into
paritytech:main
from
fanyang1988:features/add-digest-other
Jun 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User @fanyang1988, please sign the CLA here. |
tomaka
suggested changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just some nit.
twiggy diff reportDifference in .wasm size before and after this pull request.
|
Co-authored-by: Pierre Krieger <[email protected]>
Co-authored-by: Pierre Krieger <[email protected]>
tomaka
approved these changes
Jun 24, 2022
tomaka
added a commit
to tomaka/substrate-lite-1
that referenced
this pull request
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DigestItem type in substrate has a other type:
This will be used for some chain based on substrate, and if use this digestitem, the smoldot will failed to sync blocks from it.
This PR fix this problem by add this type to DigestItem.