Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an error if commit too far away #2405

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jun 20, 2022

This is an amendment to #2400

It is not a problem in the GrandPa commit either if it targets a block too far away. We just save it for later.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────────
         +14 ┊ smoldot::sync::all_forks::AllForksSync<TBl,TRq,TSrc>::grandpa_commit_message::h16420afe5b974889
         +14 ┊ smoldot::sync::all_forks::FinalityProofVerify<TBl,TRq,TSrc>::perform::h06885296c1832f90
         +28 ┊ Σ [2 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jun 20, 2022
@mergify mergify bot merged commit df38957 into paritytech:main Jun 20, 2022
@tomaka tomaka deleted the no-err-too-far branch June 20, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants