Change max number of pinned blocks to max number of finalized pinned blocks

[tomaka]

Close #2217

As suggested here: #2215 (comment)

Since the user can't control the number of non-finalized blocks, it makes sense for the non-finalized blocks to not be counted towards the limit. It is entirely smoldot's fault if the number of non-finalized blocks becomes too high (well, it might be because of a problem with the chain itself, but basically it's smoldot's problem and not the JSON-RPC client's problem).

The limit is now a NonZeroUsize. Previously, if the limit passed as parameter was too low, we would immediately close the subscription. Now, it is impossible to have a limit that is too low, because we always start with exactly 1 finalized pinned block, which is always <= the value inside of a NonZeroUsize.

Note that this doesn't require any change to https://github.com/paritytech/json-rpc-interface-spec/, as the number of pinned blocks is at the discretion of the implementation.

I've also reduced the hardcoded limits at some places, since we no longer take the non-finalized blocks into account.

[mergify]

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

[github-actions]

twiggy diff report

Difference in .wasm size before and after this pull request.

---

 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      +11616 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h1d6e99c02f476918
      -11616 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::he90f8ecfe84fa919
      +11199 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h70d54b7c5a373556
      -11199 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hdc88d3c398a0e8a6
       +4643 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h08a2a396caea48e9
       -4643 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h62daf6aecbea5593
       -2567 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hefda7bc9d6db4d0e
       +2529 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h2df0001c0fbc5b31
       +1998 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h881937e0a6dbbdaa
       -1998 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hce2f06a5c9dc4086
       +1909 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd1292a04ca2b80a2
       -1909 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd560655a9837dc90
       +1752 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h459ab1ea5671f3ab
       -1752 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hbd017c6f38a5bb7e
       -1535 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb22b3a289a10ae37
       +1535 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc1451464f5297055
        -971 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h62aecaac7e805db7
        +971 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb73c4ab43511774c
        +475 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light_base::sync_service::parachain::start_parachain<smoldot_light_wasm::platform::Platform>::{{closure}}>>::ha085459af51c7049
        -475 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light_base::sync_service::parachain::start_parachain<smoldot_light_wasm::platform::Platform>::{{closure}}>>::hf4fb754a89535b68
         +90 ┊ ... and 91 more.
         -29 ┊ Σ [111 Total Rows]

[melekes]

👍