Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more missing calls to nom::combinator::complete #2355

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jun 8, 2022

Similar to #2340
There's another code pattern where I don't call finish but I manually match the error and use unreachable!(). This PR fixes it as well.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────
        +170 ┊ <F as nom::internal::Parser<I,O,E>>::parse::h5d0ac7a87023dd6b
        +170 ┊ <F as nom::internal::Parser<I,O,E>>::parse::h8d4ee6d7d9a70fdd
        +134 ┊ <F as nom::internal::Parser<I,O,E>>::parse::h99c027afdf604af8
          +8 ┊ smoldot::network::protocol::block_request::decode_block_response::h35182f468af63c22
        +767 ┊ Σ [4 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jun 9, 2022
@mergify mergify bot merged commit 8d5e809 into paritytech:main Jun 9, 2022
@tomaka tomaka deleted the more-complete-missing branch June 9, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants