-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to established connections #2323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.
twiggy diff reportDifference in .wasm size before and after this pull request.
|
This PR is a general clean-up of the single stream connection code. It fixes many small issues, and also handles the shutdown phase more properly. We now properly handle incoming GoAway frames, and have the possibility to send some. Can be reviewed commit by commit. I understand that this code is generally extremely complicated, but I don't really have a good solution for this. Networking code *is* extremely complicated, both in terms of logic and implementation. Maybe a solution is tests, such as #2323, but at the moment the code isn't even robust enough to have tests.
Tests are now passing. Will add more tests. |
This PR is definitely a bit embarrassing: it revealed many unimplemented things, which now are. |
Adds a test to the established connections.
I initially just wanted to write regression tests, unfortunately the first test I wrote doesn't pass because of this generally messy piece of code.
I'm going to fix that generally messy piece of code before we can merge this PR.
Update:
Working on the tests revealed a couple of bugs that I've fixed.
Additionally, I've also made a change where we now pass a timeout to
open_notifications_substream
to allow configuring it and to make it similar toadd_request
.