Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a debug assertion in Noise handshake when expected_len == 0 #2322

Merged
merged 1 commit into from
May 29, 2022
Merged

Fix a debug assertion in Noise handshake when expected_len == 0 #2322

merged 1 commit into from
May 29, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented May 27, 2022

This is similar to #2321, but since it's only a debug_assert! it's not a big deal.

mergify[bot]
mergify bot approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

melekes
melekes approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label May 29, 2022
@mergify mergify bot merged commit 7620746 into paritytech:main May 29, 2022
@tomaka tomaka deleted the noise-other-panic branch May 29, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @melekes