Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant field in service.rs #2298

Merged
merged 1 commit into from
May 18, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented May 18, 2022

Before #2264, we were maintaining an additional redundant list of connections in service.rs in order to avoid having to lock a mutex.
After the big refactor, this redundant list is no longer needed as we can directly access the list in the underlying data structure.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────
      -10473 ┊ smoldot::network::service::ChainNetwork<TNow>::next_event::h8c3fbc17c9efa90a
      +10386 ┊ smoldot::network::service::ChainNetwork<TNow>::next_event::hd1aff972b8b32faf
       -1274 ┊ smoldot::network::service::ChainNetwork<TNow>::new::h1194499a5e459cbf
       +1211 ┊ smoldot::network::service::ChainNetwork<TNow>::new::h39de0984c66b61ed
        -928 ┊ smoldot::network::service::ChainNetwork<TNow>::next_start_connect::h55983c9a6cec2033
        +928 ┊ smoldot::network::service::ChainNetwork<TNow>::next_start_connect::hcfb51e434abb3f14
        -860 ┊ smoldot::network::service::ChainNetwork<TNow>::discover::h4fae1d452d8919d3
        +860 ┊ smoldot::network::service::ChainNetwork<TNow>::discover::h94c6580e84bc2764
        +721 ┊ smoldot::network::service::ChainNetwork<TNow>::discover::h08a464fb88d3f722
        -721 ┊ smoldot::network::service::ChainNetwork<TNow>::discover::h9ec50706633ae426
        +698 ┊ smoldot::network::service::ChainNetwork<TNow>::discover::h003dd42f7ea8a06a
        -698 ┊ smoldot::network::service::ChainNetwork<TNow>::discover::h473c4c6211b9f198
        -588 ┊ smoldot::network::service::ChainNetwork<TNow>::respond_identify::hb6f86ca10a3d59d7
        +588 ┊ smoldot::network::service::ChainNetwork<TNow>::respond_identify::hbf285c3d3cacdedd
        -547 ┊ smoldot::network::service::ChainNetwork<TNow>::pending_outcome_err::h8354388b734ab859
        +543 ┊ smoldot::network::service::ChainNetwork<TNow>::pending_outcome_err::h60cac5a8ebddecde
        +521 ┊ smoldot::network::service::ChainNetwork<TNow>::start_kademlia_discovery_round::ha6970526e10c4c98
        -521 ┊ smoldot::network::service::ChainNetwork<TNow>::start_kademlia_discovery_round::he9e4d0fc443e8deb
        +448 ┊ smoldot::network::service::ChainNetwork<TNow>::start_blocks_request_inner::h4348c053d975dd9e
        -448 ┊ smoldot::network::service::ChainNetwork<TNow>::start_blocks_request_inner::hbca2a368f08ce85d
         -12 ┊ ... and 55 more.
        -166 ┊ Σ [75 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label May 18, 2022
@mergify mergify bot merged commit b042717 into paritytech:main May 18, 2022
@tomaka tomaka deleted the rm-conn-services branch May 18, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants