-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport change to checkpoints format #2219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.
twiggy diff reportDifference in .wasm size before and after this pull request.
|
I've opened paritytech/polkadot-sdk#60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
paritytech/substrate#9284 accidentally modified the checkpoints format. This PR backports this change.
We maintain compatibility with older checkpoints by not actually adding the new field but instead using
decode
instead ofdecode_all
. Contrary todecode_all
,decode
succeeds even if there is data remaining after the decoded value, meaning that the additional field will not lead to an error.This PR also updates the checkpoint in the Polkadot spec. I tested this PR with Westend (that uses an old checkpoint) and Polkadot (that uses a new checkpoint).