Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sub_utils under json_rpc_service/state_chain #2214

Merged
merged 10 commits into from
Apr 7, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 6, 2022

As promised in #2180, this moves the sub_utils module to json_rpc_service/state_chain where it is more appropriate.

Can be easily reviewed commit by commit.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────
       -3281 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::he949dd6e451ef817
       +3275 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hfb4c1399da14b961
       +2646 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h8423237a0062e1c8
       -2646 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd5de7b608b1f0ea1
       +2478 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h2cb2562b51aa6264
       -2478 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h53b16dac65eb8b39
       -2013 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha9c4cb87a6684929
       +2010 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc06f14b092549f82
       -1998 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h4a630bfc0efeee45
       +1992 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h9a209a929061c046
       -1984 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h6a8222bf10b001db
       +1984 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc72d6864d9e9fde7
       -1878 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h1797f12ff7babae0
       -1878 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb1fac59568bb73b3
       +1872 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h53dc1582444caeb8
       +1872 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h6a247f9080865cde
       +1752 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h3387e347e85c9263
       -1750 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h1313908663adf103
       -1726 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h6bf14cbe739e3ee9
       +1726 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hfa400005dc90d523
        -428 ┊ ... and 253 more.
       -2393 ┊ Σ [273 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Apr 7, 2022
@mergify mergify bot merged commit eb55160 into paritytech:main Apr 7, 2022
@tomaka tomaka deleted the move-sub-utils branch April 7, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants