Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly fix the regression again #2210

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Properly fix the regression again #2210

merged 2 commits into from
Apr 5, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 5, 2022

This is #2201 again

This time I've made sure that when_known was indeed notified before every time we do lock.tree = ....

mergify[bot]
mergify bot approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 5, 2022 •
edited
Loading

Merging quickly as insubstantial, so that I can release a version afterwards

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────
         +30 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hddcb64d046112f69
         +30 ┊ Σ [1 Total Rows]

@tomaka tomaka merged commit c3fa58d into paritytech:main Apr 5, 2022
@tomaka tomaka deleted the another-regression-fix branch April 5, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomaka