Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make set_parent_hash mark entire chain as bad #2121

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Make set_parent_hash mark entire chain as bad #2121

merged 4 commits into from
Mar 7, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 6, 2022

If a certain block is bad, all its descendants are meant to be marked as bad as well.
When you call set_parent_hash, and the parent is bad, the immediate child is set as bad. This PR also sets the entire chain of descendants as bad.

mergify[bot]
mergify bot approved these changes Mar 6, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────
          +6 ┊ smoldot::sync::all_forks::disjoint::DisjointBlocks<TBl>::set_parent_hash::h1e36a72fc3f087ef
          +6 ┊ Σ [1 Total Rows]

melekes
melekes approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka
Copy link
Contributor Author

tomaka commented Mar 7, 2022 •
edited
Loading

Waiting for #2122 to merge this

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Mar 7, 2022
@mergify mergify bot merged commit b8b7a1f into paritytech:main Mar 7, 2022
@tomaka tomaka deleted the bad-propagates-to-children branch March 7, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @melekes