Don't notify the same parahead twice

[tomaka]

Fix #2088

See #2088 for context.
What this PR fixes is that we no longer notify about a new parachain block if the same parachain block was already in another relay chain fork.

[mergify]

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

[github-actions]

twiggy diff report

Difference in .wasm size before and after this pull request.

---

 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      +11448 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc5119dd4530cce28
      -11322 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h21ca2f484c5d3fb9
        -475 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light_base::sync_service::parachain::start_parachain<smoldot_light_wasm::platform::Platform>::{{closure}}>>::h307ec6731e949e8e
        +475 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light_base::sync_service::parachain::start_parachain<smoldot_light_wasm::platform::Platform>::{{closure}}>>::h8b33e805fabaffc5
        +436 ┊ itertools::Itertools::join::h62e25263dfd20ced
        -436 ┊ itertools::Itertools::join::h6dffde9b633a4942
        +436 ┊ itertools::Itertools::join::h91b083d866abf3c6
        +436 ┊ itertools::Itertools::join::hdb29b4583beeaa5e
        -436 ┊ itertools::Itertools::join::he78dffcb4968026a
        -436 ┊ itertools::Itertools::join::hec4d46004f1e7850
        -427 ┊ core::ops::function::impls::<impl core::ops::function::FnMut<A> for &mut F>::call_mut::h843d419d1ce31cb7
        +427 ┊ core::ops::function::impls::<impl core::ops::function::FnMut<A> for &mut F>::call_mut::hbdb05dd0998664d5
        -375 ┊ <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::h318fb9d717d83491
        +375 ┊ <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::h984cf43e3e871b79
        -322 ┊ <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold::h2ef55bbecc240cb8
        +322 ┊ <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold::hbee2f85a919e49bd
        -277 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::he397954f8ecb9f0c
        +277 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::hfdcdb6e3580200cd
        +266 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::ha1f5e4545d7315b6
        -266 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::hac7ed75e08afc14c
        +295 ┊ ... and 103 more.
       +1078 ┊ Σ [123 Total Rows]

[tomaka]

When I tested this, I encountered a panic:

Error: panicked at 'assertion failed: parent_hash == finalized_block.hash ||\n tree.input_iter_ancestry_order().any(|b|\n parent_hash == b.user_data.hash\n &&\n b.async_op_user_data.is_some())', /home/tomaka/Projets/smoldot/bin/light-base/src/runtime_service.rs:648:25

[melekes]

👍