Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the block's parent in block announces #2105

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 25, 2022

When investigating #2088 I realized that we were missing this critical info.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────
         +57 ┊ smoldot_light_base::sync_service::standalone::Task<TPlat>::inject_network_event::he982285972697c59
         +16 ┊ data[0]
         +73 ┊ Σ [2 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Feb 25, 2022
@mergify mergify bot merged commit 2a2ef00 into paritytech:main Feb 25, 2022
@tomaka tomaka deleted the log-parent-hash-in-block-announces branch February 25, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants