Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new JSON-RPC API #1687

Merged
merged 32 commits into from
Dec 17, 2021
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 26, 2021

No description provided.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      +38107 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::h8ca46f8df3bab1e8
      +26706 ┊ smoldot_light_base::json_rpc_service::Background<TPlat>::handle_request::{{closure}}::h647cd2dda3005c3a
      -25913 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hbc9ef0aa1d7b3e82
      -20738 ┊ smoldot_light_base::json_rpc_service::Background<TPlat>::handle_request::{{closure}}::h814c28d60689656a
       +9175 ┊ smoldot::json_rpc::methods::Response::to_json_response::h5374dfbcc5e7f708
       -7458 ┊ smoldot::json_rpc::methods::Response::to_json_response::h76d237959e0aa804
       +5637 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h75e3c404935bda12
       +5137 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::h0dce54507989f4ed
       +4661 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h611f0d68727fbab0
       +3934 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::hcdcff17e07431305
       +3728 ┊ data[0]
       -3511 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::h2cc9121b794e44a7
       +3133 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::hcb2f60ff08ded999
       +2619 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light_base::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::h4cde20be6a558ed0
       +2443 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::h6efea535acd1a7fd
       -1994 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light_base::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::h0d6588cebb4e2815
       +1866 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::ha93c49e1ba74321b
       +1866 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::hdedae2f4d9206499
       -1681 ┊ <&T as core::fmt::Display>::fmt::h5de02bc302658fc5
       +1681 ┊ <&T as core::fmt::Display>::fmt::hf3dbae77c0ef0d2f
      +53407 ┊ ... and 876 more.
     +146822 ┊ Σ [896 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Dec 17, 2021
@tomaka tomaka marked this pull request as ready for review December 17, 2021 16:38
@mergify mergify bot merged commit d1c022c into paritytech:main Dec 17, 2021
@tomaka tomaka deleted the new-json-rpc-api-impl branch December 17, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant