Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warp sync progress report isn't working correctly #3015

Closed
tomaka opened this issue Nov 18, 2022 · 0 comments · Fixed by #3044
Closed

Warp sync progress report isn't working correctly #3015

tomaka opened this issue Nov 18, 2022 · 0 comments · Fixed by #3044

Comments

@tomaka
Copy link
Contributor

tomaka commented Nov 18, 2022

#2976 was misimplemented. We're using as_chain_information to determine the finalized block, but this is not very helpful because when warp syncing it always contains the block we started syncing from.
@tomaka tomaka mentioned this issue Nov 28, 2022
Merged
@mergify mergify bot closed this as completed in #3044 Nov 28, 2022
mergify bot pushed a commit that referenced this issue Nov 28, 2022
@tomaka
Fix wrong Grandpa warp sync block being reported (#3044)
ab489e4 
Fix #3015

We now properly report the block of the fragments which we've
downloaded, as opposed to the block whose chain information we have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong Grandpa warp sync block being reported tomaka/substrate-lite-1
1 participant
@tomaka