Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic at single_stream #2740

Closed
wirednkod opened this issue Sep 12, 2022 · 3 comments · Fixed by #2785
Closed

Panic at single_stream #2740

wirednkod opened this issue Sep 12, 2022 · 3 comments · Fixed by #2785

Comments

@wirednkod
Copy link
Contributor

Got the following error with Smoldot 0.6.32 (latest extension installed 0.6.19)

Internal error in smoldot: Error: panicked at 'called Option::unwrap() on a None value', /__w/smoldot/smoldot/src/libp2p/connection/established/single_stream.rs:845:14
@tomaka
Copy link
Contributor

tomaka commented Sep 13, 2022

smoldot/src/libp2p/connection/established/single_stream.rs

Line 856 in d2c7918

.unwrap()

@tomaka
Copy link
Contributor

tomaka commented Sep 13, 2022

smoldot/src/libp2p/collection/single_stream.rs

Line 328 in d2c7918

// TODO: must verify that the substream is still valid

@tuul-wq
Copy link

tuul-wq commented Sep 26, 2022

@wirednkod just got an error in the same file, it might be connected to your catch
@substrate/smoldot-light^0.6.34

panicked at 'called Option::unwrap() on a None value', /__w/smoldot/smoldot/src/libp2p/connection/established/single_stream.rs:859:14

@tuul-wq tuul-wq mentioned this issue Sep 26, 2022
Closed
This was referenced Sep 27, 2022
Closed
Merged
@mergify mergify bot closed this as completed in #2785 Sep 28, 2022
mergify bot added a commit that referenced this issue Sep 28, 2022
@tomaka @mergify
Fix race conditions in the handling of notifications in events (#2785)
b8b194a 
Fix #2740

The logic of the handling of `NotificationsInOpenCancel` events wasn't
correct, as it wasn't taking into account the fact that everything is
asynchronous.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@tomaka tomaka mentioned this issue Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race conditions in the handling of notifications in events tomaka/substrate-lite-1
3 participants
@tomaka @wirednkod @tuul-wq