New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure determinism of PeerId encoding #2312

Closed

tomaka opened this issue May 23, 2022 · 0 comments · Fixed by #2326

Contributor

tomaka commented May 23, 2022 •

edited

Loading

The "Keys" section of the libp2p specs mention that the public key protobuf must be encoded a certain way, in order to achieve determinism.

This isn't currently enforced by smoldot.

This needs to be done both for the encoding and decoding.

Related: #2285

tomaka mentioned this issue

Perform the protobuf encoding and decoding manually #2326

Merged

mergify bot closed this as completed in #2326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment