Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a solution for the protobuf files #2285

Closed
tomaka opened this issue May 16, 2022 · 1 comment · Fixed by #2326
Closed

Figure out a solution for the protobuf files #2285

tomaka opened this issue May 16, 2022 · 1 comment · Fixed by #2326

Comments

@tomaka
Copy link
Contributor

tomaka commented May 16, 2022

Right now you have to install cmake in order to compile the protobuf compiler in order to parse a protobuf file at compilation time.
This is really crappy.

Additionally, the auto-generated Rust files have a ton of clippy warnings.

IMO we should do this differently, for example not do any compilation time generation of Rust code, and instead manually generate and parse the encoded payloads. Or include the generated Rust code into the smoldot repo.

@tomaka
Copy link
Contributor Author

tomaka commented May 24, 2022

The format isn't very complicated: https://developers.google.com/protocol-buffers/docs/encoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant