Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "expose ecdsa_sign_prehashed in sp-io" #1968

Closed
tomaka opened this issue Jan 31, 2022 · 0 comments · Fixed by #2120
Closed

Backport "expose ecdsa_sign_prehashed in sp-io" #1968

tomaka opened this issue Jan 31, 2022 · 0 comments · Fixed by #2120
Assignees
@melekes

Comments

@tomaka
Copy link
Contributor

tomaka commented Jan 31, 2022

paritytech/substrate#10119
@tomaka tomaka mentioned this issue Jan 31, 2022
Closed
melekes added a commit that referenced this issue Mar 4, 2022
@melekes
implement ecdsa sign, sign_prehashed and verify_prehashed
b0b2c05 
Closes #1968
@melekes melekes mentioned this issue Mar 4, 2022
Merged
@melekes melekes self-assigned this Mar 4, 2022
@mergify mergify bot closed this as completed in #2120 Mar 7, 2022
mergify bot added a commit that referenced this issue Mar 7, 2022
@melekes @mergify
implement ecdsa sign, verify, sign_prehashed and verify_prehashed (#2120
00ba3c8 
)

* implement ecdsa sign, sign_prehashed and verify_prehashed

Closes #1968

* fix compilation errors and return an error

if we fail to parse secret key

* implement ecdsa verify

* remove outdated comment

#2120 (comment)

* avoid extra copy

* improve comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement ecdsa sign, verify, sign_prehashed and verify_prehashed paritytech/smoldot
2 participants
@melekes @tomaka