Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert default proof size back to 64 KB #7115

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

KiChjang
Copy link
Contributor

According to #7081 (comment), we did not actually need to set the DEFAULT_PROOF_SIZE to 0 when we are converting from a V2 Transact to V3. 64 KB was good enough.

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C3-medium PR touches the given topic and has a medium impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 22, 2023
@paritytech-ci paritytech-ci requested review from a team April 22, 2023 14:42
@bkchr
Copy link
Member

bkchr commented Apr 22, 2023

Instead of random guessing, we should finally add some test based on the linked comment.

@xlc
Copy link
Contributor

xlc commented Apr 22, 2023

#7077 (comment)

@girazoki
Copy link
Contributor

I tested with chopsticks and I have been able to do a hrmp->close_channel and a balance->transfer Transact operations.

@KiChjang
Copy link
Contributor Author

KiChjang commented Apr 24, 2023

Thanks @girazoki for testing! I've also enhanced our unit test in the Kusama runtime to specifically check for cases like these so that we can catch problems similar to this way earlier in our development process. I've tested it so that the unit test actually fails when I set the DEFAULT_PROOF_SIZE to 0.

@KiChjang
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 3bc63cb into master Apr 24, 2023
@paritytech-processbot paritytech-processbot bot deleted the kckyeung/xcm-revert-default-pov branch April 24, 2023 12:24
ordian added a commit that referenced this pull request Apr 26, 2023
* master:
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
ordian added a commit that referenced this pull request Apr 26, 2023
* master: (39 commits)
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
  update rocksdb to 0.20.1 (#7113)
  Reduce base proof size weight component to zero (#7081)
  PVF: Move PVF workers into separate crate (#7101)
  Companion for #13923 (#7111)
  update safe call filter (#7080)
  PVF: Don't dispute on missing artifact (#7011)
  XCM: Properly set the pricing for the DMP router (#6843)
  pvf: Update docs for PVF artifacts (#6551)
  Bump syn from 2.0.14 to 2.0.15 (#7093)
  Companion for substrate#13771 (#6983)
  Added Dwellir Nigeria bootnodes. (#7097)
  ...
KiChjang added a commit that referenced this pull request May 3, 2023
* Revert default proof size back to 64 KB

* Fix test expectations

* Enhance unit test

* cargo fmt

* Fix comment
KiChjang added a commit that referenced this pull request May 3, 2023
* Revert default proof size back to 64 KB

* Fix test expectations

* Enhance unit test

* cargo fmt

* Fix comment
KiChjang added a commit that referenced this pull request May 3, 2023
* Revert default proof size back to 64 KB

* Fix test expectations

* Enhance unit test

* cargo fmt

* Fix comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C3-medium PR touches the given topic and has a medium impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants