Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update XCM template and weights #7084

Closed
wants to merge 2 commits into from
Closed

Update XCM template and weights #7084

wants to merge 2 commits into from

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Apr 14, 2023 •
edited
Loading

Merged into #7077

The CI script does not actually update the XCM weights in the release process here. Therefore now manually updating them.
Also the XCM weight template is still on V1…

Changes:

  • Update XCM weight template to output PoV
  • Re-benchmark for Kusama, Westend and Rococo.

ggwpez added 2 commits April 14, 2023 15:10
@ggwpez
Make CI fail on old files
c82f5cc 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Update template
71983ac 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member Author

ggwpez commented Apr 14, 2023

bot bench $ xcm kusama pallet_xcm_benchmarks::generic
bot bench $ xcm kusama pallet_xcm_benchmarks::fungible
bot bench $ xcm westend pallet_xcm_benchmarks::generic
bot bench $ xcm westend pallet_xcm_benchmarks::fungible
bot bench $ xcm rococo pallet_xcm_benchmarks::generic
bot bench $ xcm rococo pallet_xcm_benchmarks::fungible

@ggwpez ggwpez mentioned this pull request Apr 14, 2023
Merged
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T6-XCM This PR/Issue is related to XCM. B1-note_worthy Changes should be noted in the release notes labels Apr 14, 2023
@ggwpez ggwpez changed the title Update XCM weights Update XCM template and weights Apr 14, 2023
@ggwpez ggwpez marked this pull request as draft April 14, 2023 13:20
@ggwpez ggwpez added T1-runtime This PR/Issue is related to the topic “runtime”. and removed T6-XCM This PR/Issue is related to XCM. labels Apr 14, 2023
@ggwpez
Copy link
Member Author

ggwpez commented Apr 14, 2023 •
edited
Loading

Turns out there is one benchmark missing 🤦‍♂️
Merging these chances into #7077

bot cancel
bot clean

@ggwpez ggwpez closed this Apr 14, 2023
@command-bot
Copy link

command-bot bot commented Apr 14, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2685372 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2685372/artifacts/download.

@command-bot
Copy link

command-bot bot commented Apr 14, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2685376 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2685376/artifacts/download.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ggwpez