This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Availability: provisioner bitfield metrics #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
github-actions
bot
added
the
A3-in_progress
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
changed the title
sandreim
added
A0-please_review
sandreim
commented
May 13, 2022
eskimor
approved these changes
May 13, 2022
|
also measurements showed that a second for fetching chunks should be plenty (Kusama). |
bkchr
reviewed
May 13, 2022
This reverts commit 7563051.
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
changed the title
ordian
approved these changes
May 19, 2022
ordian
added
B0-silent
drahnr
reviewed
May 19, 2022
drahnr
approved these changes
May 19, 2022
Co-authored-by: Bernhard Schuster <[email protected]>
eskimor
approved these changes
May 19, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By reducing the bitfield signing delay by 500ms, we increase the gossip time by the same amount, trading off bits in favor of better bitfield propagation. It is better to have less bits, than less signed bitfields, because we expect chunks to be already fetched by next block such that we recover the bits. If the gossip duration shorter, chances are that bitfields might not make it repeatedly.