Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

dyn overseer channel capacity #5454

Merged
merged 8 commits into from
May 5, 2022
Merged

dyn overseer channel capacity #5454

merged 8 commits into from
May 5, 2022

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented May 5, 2022

Closes #5436

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 5, 2022
vstakhov
vstakhov approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@vstakhov vstakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build should be fixed first anyway :)

node/overseer/overseer-gen/proc-macro/src/impl_builder.rs Outdated Show resolved Hide resolved
node/overseer/overseer-gen/proc-macro/src/impl_builder.rs Show resolved Hide resolved
node/overseer/overseer-gen/proc-macro/src/impl_builder.rs Show resolved Hide resolved
@drahnr drahnr force-pushed the bernhard-dyn-overseer-channel-capacity branch from 50aded2 to d0bf0d9 Compare May 5, 2022 08:52
@drahnr drahnr self-assigned this May 5, 2022
@drahnr drahnr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 5, 2022
@drahnr drahnr requested a review from eskimor May 5, 2022 08:54
@drahnr drahnr force-pushed the bernhard-dyn-overseer-channel-capacity branch from 6052932 to e8bc9f9 Compare May 5, 2022 08:58
eskimor
eskimor approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, more than I asked for 🥇

@eskimor eskimor mentioned this pull request May 5, 2022
Closed
@drahnr
Copy link
Contributor Author

drahnr commented May 5, 2022

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for c430a67

@drahnr drahnr merged commit decdbed into master May 5, 2022
@drahnr drahnr deleted the bernhard-dyn-overseer-channel-capacity branch May 5, 2022 15:22
drahnr added a commit to paritytech/cumulus that referenced this pull request May 6, 2022
@drahnr
fix fallout of paritytech/polkadot#5454
3f55169
paritytech-processbot bot pushed a commit to paritytech/cumulus that referenced this pull request May 6, 2022
@RGafiyatullin @drahnr
A companion PR to the paritytech/substrate#10995 (#1162)
0eb8efa 
* Substrate API change: paritytech/substrate#8103

* fix fallout of paritytech/polkadot#5454

* update lockfile for {"polkadot"}

Co-authored-by: Bernhard Schuster <[email protected]>
Co-authored-by: parity-processbot <>
WebWizrd8 added a commit to WebWizrd8/cumulus that referenced this pull request Nov 21, 2022
@WebWizrd8 @drahnr
A companion PR to the paritytech/substrate#10995 (#1162)
5eb1727 
* Substrate API change: paritytech/substrate#8103

* fix fallout of paritytech/polkadot#5454

* update lockfile for {"polkadot"}

Co-authored-by: Bernhard Schuster <[email protected]>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@eskimor eskimor eskimor approved these changes

@vstakhov vstakhov vstakhov approved these changes

Assignees

@drahnr drahnr

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce subsystem channel size on test networks
4 participants
@drahnr @vstakhov @eskimor @ordian