Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

introduce expander #4974

Merged
merged 5 commits into from
Feb 23, 2022
Merged

introduce expander #4974

merged 5 commits into from
Feb 23, 2022

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Feb 23, 2022

Avoid clutter in the codebase, that just complicates things and isn't polkadot specific at all.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Feb 23, 2022
@drahnr drahnr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. I8-refactor Code needs refactoring. labels Feb 23, 2022
@drahnr drahnr self-assigned this Feb 23, 2022
@drahnr drahnr requested review from vstakhov and sandreim February 23, 2022 10:15
sandreim
sandreim approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + 2 nits

node/overseer/overseer-gen/README.md Outdated Show resolved Hide resolved
node/overseer/Cargo.toml Outdated Show resolved Hide resolved
vstakhov
vstakhov approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@vstakhov vstakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drahnr @sandreim
spelling
0b396bc 
Co-authored-by: Andrei Sandu <[email protected]>
drahnr
drahnr commented Feb 23, 2022
View reviewed changes
node/overseer/Cargo.toml Outdated Show resolved Hide resolved
@drahnr
Copy link
Contributor Author

drahnr commented Feb 23, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit c4080f1 into master Feb 23, 2022
@paritytech-processbot paritytech-processbot bot deleted the bernhard-expander branch February 23, 2022 14:24
@nuke-web3 nuke-web3 mentioned this pull request Mar 15, 2022
Closed
@librelois librelois mentioned this pull request Mar 21, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandreim sandreim sandreim approved these changes

@vstakhov vstakhov vstakhov approved these changes

Assignees

@drahnr drahnr

Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. I8-refactor Code needs refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drahnr @vstakhov @sandreim