This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow verification of sent XCMs in benchmarks #4605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
3 tasks
KiChjang
commented
Dec 28, 2021
| @@ -64,7 +62,7 @@ pub fn mock_worst_case_holding() -> MultiAssets { | |||
| const HOLDING_FUNGIBLES: u32 = 99; | |||
| const HOLDING_NON_FUNGIBLES: u32 = 99; | |||
| let fungibles_amount: u128 = 100; | |||
| (0..HOLDING_FUNGIBLES) | |||
| (1..=HOLDING_FUNGIBLES) | |||
There was a problem hiding this comment.
This is done here because the XCM executor's holding register automatically removes any fungible assets that have an amount of 0, which would cause some tests to fail as the worst case holding expects a non-existent GeneralIndex(0) asset to be there.
|
This unfortunately will not work right? Because when running verification on an actual production chain, this mock thing wont exist. So this only works for tests, but verification in benchmarking is quite a bit more than that. We need some general trait / implementation for both tests and the real queue system. |
|
Yeah, this is definitely not going to work, closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for paritytech/polkadot-sdk#900.
Creates an additional
TestSendXcmstruct in mocks, which is essentially a global queue of XCMs that are meant to be sent by theXcmSenderas configured in the XCM executor. This will allow us to inspect the outgoing messages by reading off of the queue, and thereby verifying the integrity of our XCM benchmarks.