This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
companion for #8783 - jsonrpsee #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
A3-in_progress
niklasad1
requested review from
acatangiu,
adoerr,
antonio-dropulic,
svyatonik and
tomusdrw
as code owners
github-actions
bot
added
A0-please_review
This was referenced Dec 2, 2021
niklasad1
force-pushed
the
dp-jsonrpsee-integration-companion
branch
from
5203666 to
24b0def
Compare
niklasad1
added
the
A4-companion
jsdw
approved these changes
May 9, 2022
jsdw
reviewed
May 9, 2022
| @@ -25,7 +25,7 @@ use std::collections::HashMap; | |||
|
|
|||
| const DEFAULT_PROMETHEUS_PORT: u16 = 9616; | |||
|
|
|||
| #[substrate_test_utils::test] | |||
| #[substrate_test_utils::test(flavor = "multi_thread")] | |||
There was a problem hiding this comment.
@niklasad1 is it something like this that maybe leads to the issue with port 9944 being hardcoded in the test code being hit?
There was a problem hiding this comment.
most likely, I have pushed the latest stuff that hopefully fixes that.
dvdplm
approved these changes
May 10, 2022
added 2 commits
May 10, 2022 08:52
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 66113d3 |
22 tasks
This was referenced Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.