Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

dockerfiles: upgrade to ubuntu:20.04; some chore #3828

Merged
merged 3 commits into from
Sep 13, 2021
Merged

dockerfiles: upgrade to ubuntu:20.04; some chore #3828

merged 3 commits into from
Sep 13, 2021

Conversation

TriplEight
Copy link
Contributor

I'm upgrading the CI image from being based on debian:buster to ubuntu:20.04, some details: paritytech/scripts#309
The binaries produced in our new CI image will be linked by the newer GLIBC so won't be executable in debian:

/usr/local/bin/adder-collator: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /usr/local/bin/adder-collator)
/usr/local/bin/adder-collator: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /usr/local/bin/adder-collator)

@TriplEight TriplEight added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 10, 2021
@TriplEight TriplEight self-assigned this Sep 10, 2021
@TriplEight TriplEight requested a review from bkchr September 10, 2021 17:03
This was referenced Sep 10, 2021
Merged
Merged
TriplEight
TriplEight commented Sep 13, 2021
View reviewed changes
bridges/deployments/networks/OpenEthereum.Dockerfile
@@ -1,4 +1,4 @@
FROM ubuntu:xenial AS builder
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomusdrw is this image relevant to Polkadot?
Also, Xenial (16.04) is out of standard support since April 2021, our containers policy is not happy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't think so. If possible please avoid touching bridges code in this repo, it's only a clone of the bridges repository and the changes are better done there first and then synced here to avoid conflicts.

Is it caught by some blanket CI checks? Can we ignore bridges sub-dir from any checks of this kind? In the future the plan is to integrate the bridges code more closely with Polkadot/Substrate repositories, but for now we would rather keep focus on making sure the code works correctly in our repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, a more general question was "what the entire bridges repo does here?" and now I get it, thanks. I'll make a change in bridges then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a git subtree, because we want to use some of the crates from bridges repo, but keep working on the separately. Other option is referencing crates using git repo, but that makes it cumbersome in case of compilation errors (i.e. companion PR system).

chevdor
chevdor suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dealing with curl in all the images would be a good thing security-wise.

scripts/docker/release.Dockerfile Show resolved Hide resolved
scripts/docker/release.Dockerfile Show resolved Hide resolved
@TriplEight TriplEight mentioned this pull request Sep 13, 2021
Closed
@TriplEight TriplEight merged commit dee1484 into master Sep 13, 2021
@TriplEight TriplEight deleted the 3x8_upgrade_to_ubuntu2004 branch September 13, 2021 12:34
ordian added a commit that referenced this pull request Sep 14, 2021
@ordian
Merge branch 'master' into bernhard-malus-fx
99cb6e0 
* master:
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
ordian added a commit that referenced this pull request Sep 15, 2021
@ordian
Merge branch 'master' into rh-approval-wakeups-update
664573c 
* master: (21 commits)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
  Do not expire HRMP open channel requests (#3543)
  Bump tokio from 1.10.1 to 1.11.0 (#3821)
  Add words to the dictionnary (#3819)
  Add vault secrets to puplish-rustdoc job (#3816)
  ...
@GopherJ GopherJ mentioned this pull request Sep 17, 2021
Closed
@github-actions github-actions bot mentioned this pull request Oct 11, 2021
Closed
svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Mar 15, 2022
@svyatonik
sync changes from paritytech/polkadot#3828
862d38c
svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Mar 15, 2022
@svyatonik
Update Substrate/Polkadot/Cumulus references (#1353)
ff5d539 
* cumulus: 4e95228
polkadot: 975e780ae0d988dc033f400ba822d14b326ee5b9
substrate: 89fcb3e4f62d221d4e161a437768e77d6265889e

* fix refs

* sync changes from paritytech/polkadot#3828

* sync changes from paritytech/polkadot#4387

* sync changes from paritytech/polkadot#3940

* sync with changes from paritytech/polkadot#4493

* sync with changes from paritytech/polkadot#4958

* sync with changes from paritytech/polkadot#3889

* sync with changes from paritytech/polkadot#5033

* sync with changes from paritytech/polkadot#5065

* compilation fixes

* fixed prometheus endpoint startup (it now requires to be spawned within tokio context)
svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Mar 21, 2022
@svyatonik
Polkadot staging update (#1356)
f220d2f 
* Fix mandatory headers scanning in on-demand relay (#1306)

* more logging in on-demand headerss

* remove `maximal_headers_difference` concept from on-demand-relay

* another leftover from previous on-demand version

* removed extra log

* fmt

* increase relay balance guard limits for Polkadot<>Kusama bridge (#1308)

* fix benchmarks before using it in Polkadot/Kusama/Rococo runtimes (#1309)

* Endow relayer account at target chain in message benchmarks (#1310)

* endow relayer account at target chain in message benchmarks

* pick another line

* expose fee multiplier metrics in messages relay (#1312)

* Fix issues from cargo deny (#1311)

* update libp2p-core (RUSTSEC-2022-0009)

* update thread_local (RUSTSEC-2022-0006)

* time 0.2 -> time 0.3

* ignore RUSTSEC-2021-0130

* proper migration to time 0.3

* fix clippy?

* Revert "fix clippy?"

This reverts commit 53bc289.

* Add some tests to check integrity of chain constants + bridge configuration (#1316)

* add some tests to check integrity of chain constants + bridge configuration

* try to use named parameters where possible

* Encode and estimate Rococo/Wococo/Kusama/Polkadot messages (#1322)

* encode and estimate Rococo/Wococo/Kusama/Polkadot messages

* allow send-message for non-bundled chains

* weight -> dispatch-weight

* fmt

* fix spelling

* impl Decode for SignedExtensions (otherwise transaction resubmitter panicks) (#1325)

* use mortal transactions in transaction resubmitter (#1326)

* Using-same-fork metric for finality and complex relay (#1327)

* using_same_fork metric in finality relay

* support `using_different_forks` in messages relay

* added dashboards and alerts

* lockfile

* fix typo in alert expression (#1329)

* removed extra *_RUNTIME_VERSION consts from relay code (#1330)

* Reinitialize bridge relay subcommand (#1331)

* reinitialize bridge subcommand

* PolkadotToKusama in reinit-bridge

* fix clippy issues (#1332)

* Revert "Revert "override conversion rate in estimate-message-fee RPC (#1189)" (#1275)" (#1333)

This reverts commit ed7def6.

* Override conversion rate when computing message fee (#1261)

* override conversion rate when message is sent

* spelling + fmt

* add --conversion-rate-override cli option

* try to read conversion rate from cmd output

* fix output

* fmt

* fi typo in generator script (#1334)

* override conversion rate in tokens swap generator (#1335)

* fix conversion rate override in token swap (#1336)

* synchronize relay cli changes and token swap generator script (#1337)

* fixed mess with conversion rates (#1338)

* fix generator scripts to be consistent with updatedrelay output (#1339)

* Increase rate from metric when estimating fee (#1340)

* ignore errors when dumping logs and container is missing

* fixed typo

* print correct payload length

* increase conversion rate a bit when estimating fee (to avoid message rejects when rate update tx is active)

* fmt

* fix conversion rate metric in dashboards (#1341)

* get rid of '[No Data] Messages from Millau to Rialto are not being delivered' warnings (#1342)

* use DecodeLimit when decoding incoming calls (#1344)

* update regex to 1.5.5 (#1345)

* edition = "2021" (#1346)

* Mortal conversion rate updater transactions (#1257)

* merge all similar update_conversion_rate functions

* stall timeout in conversion rate update loop

* fmt

* fix

* added alerts for relay balances (#1347)

* replace From<>InboundLaneApi with direct storage reads (#1348)

* added no_stack_overflow_when_decoding_nested_call_during_dispatch test (#1349)

* ignore more "increase" alerts that are sometimes signalling NoData at startup (#1351)

* Support dedicated lanes for pallets (#962)

* pass call origin to the message verifier

* is_outbound_lane_enabled -> is_message_accepted

* trait SenderOrigin

* only accept messages from token swap pallet to token swap lane

* tests for edge cases of pay_delivery_and_dispatch_fee

* fixed origin verification

* fmt

* fix benchmarks compilation

* fix TODO with None account and non-zero message fee (already covered by tests)

* revert cargo fmt changes temporarily

* Update Substrate/Polkadot/Cumulus references (#1353)

* cumulus: 4e95228
polkadot: 975e780ae0d988dc033f400ba822d14b326ee5b9
substrate: 89fcb3e4f62d221d4e161a437768e77d6265889e

* fix refs

* sync changes from paritytech/polkadot#3828

* sync changes from paritytech/polkadot#4387

* sync changes from paritytech/polkadot#3940

* sync with changes from paritytech/polkadot#4493

* sync with changes from paritytech/polkadot#4958

* sync with changes from paritytech/polkadot#3889

* sync with changes from paritytech/polkadot#5033

* sync with changes from paritytech/polkadot#5065

* compilation fixes

* fixed prometheus endpoint startup (it now requires to be spawned within tokio context)

* update chain versions (#1358)

* update parity-scale-codec to 3.1.2 (#1359)

* fix parse_transaction on Rialto+Millau (#1360)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@chevdor chevdor chevdor approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

@s3krit s3krit Awaiting requested review from s3krit

@HCastano HCastano Awaiting requested review from HCastano

@svyatonik svyatonik Awaiting requested review from svyatonik

Assignees

@TriplEight TriplEight

Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TriplEight @tomusdrw @chevdor @bkchr