Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder dependencies' keys #6967

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier commented Dec 19, 2024

It doesn't make sense to only reorder the features array.

For example:

This makes it hard for me to compare the dependencies and features, especially some crates have a really really long dependencies list.

[dependencies]
c = "*"
a = "*"
b = "*"

[features]
std = [
  "a",
  "b",
  "c",
]

This makes my life easier.

[dependencies]
a = "*"
b = "*"
c = "*"

[features]
std = [
  "a",
  "b",
  "c",
]

Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y

@paritytech-review-bot paritytech-review-bot bot requested a review from a team December 19, 2024 15:12
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree on that

@AurevoirXavier
Copy link
Contributor Author

I hope we can merge this ASAP. Then I can happily work on other PRs.

cc @bkchr @ggwpez @kianenigma 🙏

@kianenigma
Copy link
Contributor

Yes, very much like this.

For FRAME pallets, we also alleviate this by encouraging users to use polkadot-sdk and/or polkadot-sdk-umbrella crates, being refactored in #6504

@@ -17,10 +17,10 @@ codec = { workspace = true, default-features = true }
url = { workspace = true }

# Substrate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR maybe, but I'm also not a huge fan of dependencies being separated with comments like this. If we're sorting them now I think it's a good time to remove them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought about this before. I agree you. Since they have already been "prefixed". It's easy to distinguish.

@bkchr bkchr enabled auto-merge December 20, 2024 13:22
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Dec 20, 2024
@bkchr
Copy link
Member

bkchr commented Dec 20, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 20, 2024

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7944682 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 19-13d52630-e724-47e8-b747-bf50aebb263a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 20, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7944682 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7944682/artifacts/download.

@bkchr bkchr disabled auto-merge December 20, 2024 17:35
@bkchr bkchr merged commit a843d15 into paritytech:master Dec 20, 2024
195 of 200 checks passed
@AurevoirXavier AurevoirXavier deleted the reorder-keys branch December 21, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants