Snowbridge: Emit sent event from BH to AH #6965
Open
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrong
changed the title
yrong
changed the title
yrong
force-pushed
the
emit-xcm-event
branch
from
05e56c4 to
4d754da
Compare
acatangiu
reviewed
Dec 19, 2024
| @@ -160,6 +160,8 @@ pub mod pallet { | |||
| }, | |||
| /// Set OperatingMode | |||
| OperatingModeChanged { mode: BasicOperatingMode }, | |||
| /// A XCM message was sent. | |||
| Sent { destination: Location, message: Xcm<()>, message_id: XcmHash }, | |||
There was a problem hiding this comment.
Including the full XCM message in the event makes it too big. You can add debug logging for full XCM, but for the event topic_id and message_id should be enough.
Suggested change
| Sent { destination: Location, message: Xcm<()>, message_id: XcmHash }, | |
| Sent { destination: Location, message_id: XcmHash, topic_id: XcmHash }, |
You can populate topic_id for example like this.
There was a problem hiding this comment.
Btw: message_id is generated from Ethereum and we sent it through all the way along. By using WithUniqueTopic the topic_id is just same as message_id(i.e. the t of the last instruction SetTopic(t))
yrong
force-pushed
the
emit-xcm-event
branch
from
c0a33e8 to
fab5bc9
Compare
yrong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentevent for the xcm to AH.MessageReceivedevent ahead for less confusion.